New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set `scriptRW` back to empty string when unable to determine script type #96

Merged

ikreymer merged 1 commit into webrecorder:main from 33forks:main

Dec 15, 2022

Contributor

oott123 commented Dec 12, 2022

Considering following case:

<script type="text/javascript">console.log("hello world!")</script>
<script type="text/json" id="myJson">{"json":true}</script>
<script type="text/javascript">console.log(document.getElementById('myJson').textContent)</script>

When parsing the first script element, scriptRW are setted to script; when it comes the second, it never set back to empty string.

It was to process unwanted result for any script block which type setted and not javascript.


          fix: don't rewrite script when type is undefined

8825fd4

ikreymer merged commit a7c3cfa into webrecorder:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet