Quick exit on redis connection error after interrupt #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection is gone, assume crawler is being terminated and exit quickly, don't attemtpt to reconnect to redis (assume crawler is also being shutdown)
tw4l
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for Browsertrix Cloud: often if the crawler and redis pods are being shutdown together, and redis exits quickly while crawler may attempt to finish current work and reconnect to redis.
If redis connection disappears after interrupt signal is received (and still there after the REDIS_ERROR_LOG_INTERVAL_SECS), assume redis has been shutdown and crawler also should exit immediately.
This results is faster shutdown times when crawl is being canceled.