Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to log errors to redis #279

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Apr 5, 2023

Fixes #278

This PR adds a --logErrorsToRedis crawler arg that when enabled adds the serialized JSON strings for all errors to Redis.

When enabled, errors are stored in Redis and serialized as requested.
@tw4l tw4l force-pushed the issue-278-log-errors-to-redis branch 3 times, most recently from 51af298 to ecaf996 Compare April 5, 2023 22:05
@tw4l tw4l marked this pull request as ready for review April 5, 2023 22:06
@tw4l tw4l requested a review from ikreymer April 5, 2023 22:06
@ikreymer ikreymer changed the title WIP: Add option to log errors to redis Add option to log errors to redis Apr 6, 2023
@tw4l tw4l merged commit 3864c76 into main Apr 11, 2023
@tw4l tw4l deleted the issue-278-log-errors-to-redis branch April 11, 2023 15:32
tw4l added a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to log crawl errors to Redis
2 participants