Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total timeout + limit redis queue retries #248

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Add total timeout + limit redis queue retries #248

merged 4 commits into from
Mar 13, 2023

Conversation

ikreymer
Copy link
Member

No description provided.

ikreymer added 4 commits March 11, 2023 12:43
@ikreymer
time limits: readd total timeount to runTask() in worker, just in case
9bb5e1e 
refactor working runTask() to either return true/false if task was timed out
if timed out, recreate the page
redis: add limit to retried URLs, currently set to 1
@ikreymer
retry: remove URL if not retrying, log removal
d449b74
@ikreymer
parse int
74c613d
@ikreymer
lint fix
ad51193
@ikreymer ikreymer requested a review from tw4l March 13, 2023 20:56
tw4l
tw4l approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we may need additional fixes in PRs to come but this makes a big improvement, thanks!

@ikreymer ikreymer merged commit 4b8a414 into main Mar 13, 2023
@tw4l tw4l deleted the retry-total-timeout-fixes branch March 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @tw4l