Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(concepts) Clarification about NODE_ENV and mode #1885

Merged
merged 1 commit into from
Mar 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/content/concepts/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ T> You can configure the `entry` property in various ways depending the needs of

## Output

The **output** property tells webpack where to emit the *bundles* it creates and how to name these files and defaults to `./dist`. You can configure this part of the process by specifying an `output` field in your configuration:
The **output** property tells webpack where to emit the *bundles* it creates and how to name these files, it defaults to `./dist`. You can configure this part of the process by specifying an `output` field in your configuration:

__webpack.config.js__

Expand Down Expand Up @@ -159,4 +159,4 @@ module.exports = {
};
```

[Learn more!](/concepts/mode)
[Learn more!](/concepts/mode)
6 changes: 4 additions & 2 deletions src/content/concepts/mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ module.exports = {
};
```

or pass it as a cli argument:

or pass it as a [CLI](/api/cli/) argument:

```bash
webpack --mode=production
Expand All @@ -33,6 +33,8 @@ Option | Description
`development` | Provides `process.env.NODE_ENV` with value `development`. Enables `NamedModulesPlugin`.
`production` | Provides `process.env.NODE_ENV` with value `production`. Enables `UglifyJsPlugin`, `ModuleConcatenationPlugin` and `NoEmitOnErrorsPlugin`.

T> Please remember that setting `NODE_ENV` doesn't automatically set `mode`.


### Mode: development

Expand Down