-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's ship the webpack 4 documentation #1856
Merged
Merged
Changes from 27 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dafbbb2
adding docs for new `output.devtoolNamespace` option and [namespace] …
MagicDuck f3c515c
adding extra lines as indicated
MagicDuck 8ccb3da
docs(config): update `hashFunction` docs based on v4 (#1761)
EugeneHlushko 7fa4fe0
docs(api): reformat index page at 80 characters / line
skipjack 388aa68
docs(api): reformat node api docs and add more details on the compiler
skipjack 4896c00
docs(api): reformat/rewrite the lead-in plugin docs and remove `tapab…
skipjack d5c0a24
docs(api): remove `module-factories.md` and `template.md`
skipjack 38e33c2
docs(api): reformat line length in plugins.md
skipjack 33caf72
docs(api): rewrite, rename, and resort the `compiler.md` page
skipjack ede8e02
docs(api): rewrite, rename, and resort the `compilation.md` page
skipjack e0f7a62
docs(api): fix sorting and start to reformat the last two plugin pages
skipjack ebe7331
docs(api): begin rewrite of the resolver page
skipjack b066b44
docs(config): fix header nesting in resolve.md
skipjack 93efa5d
docs(api): rename resolvers page for clarity and finish rewrite
skipjack 1555e7c
docs(api): make minor corrections to plugin docs
skipjack 7941097
docs(api): rewrite the parser documentation
skipjack acf7b77
docs(api): update some of the compiler hook descriptions
skipjack 7b89b9f
docs(plugins): add `ProfilingPlugin` documentation (#1830)
EugeneHlushko 4354b9a
docs(config): document `info-verbosity` option in watch.md (#1817)
EugeneHlushko b1d2779
Merge branch 'master' into next
sokra 6194853
update tree shaking guide for webpack 4
quantizor 6de8690
docs(Guides): Update Getting Started to use webpack 4
TheDutchCoder 7d1f662
docs(concepts): Update plugins.md (#1871)
arjendeblok 44eb6c9
Merge branch 'master' into next
montogeek 45db042
docs(Stats): add `buitlAt` to the example configuration (#1878)
osenvosem a44fa0a
docs(guides): add doctype to Get Started (#1874)
TheDutchCoder 38faec2
docs(API): add missing config options to cli.md (#1880)
joshunger 0c96dd5
docs(Concepts): update concepts page for v4 (#1883)
EugeneHlushko 0e545a1
update related links to be relevant for webpack 4
quantizor 9ad350d
add note about side effects and non-JS files
quantizor 2f19976
add some more advanced usage notes
quantizor c1318e1
Merge pull request #1865 from probablyup/update-se-docs
jeremenichelli 051a566
docs(concepts) Clarification about NODE_ENV and mode (#1885)
montogeek e1029fc
chore(site): Delete package-lock.json (#1917)
dhruvdutt 8b13724
docs(guides): Correct a path error in getting started example (#1899)
bingtimren bec9d42
chore: Resolve conflicts on next branch (#1923)
dhruvdutt 3197738
Merge branch 'master' into next
TheLarkInn 40d89f9
docs(api) Fix markdown lint errors
montogeek 74cb0e7
docs(api) Fix Plugins wording
montogeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this
production
by default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it throws if not supplied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows a warning:
but still bundle the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but it bundles the app as in
production
right? that's what I meant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/webpack/webpack/blob/4f399322ad1922ae7bafdeea1c4d83bf9c9851a7/lib/WebpackOptionsDefaulter.js#L284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that is the case

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we default to production so people don't have consequences for not caring about the mode: property. However, we still will warn because we want users to be aware of being able to set the property.