ISSUE 947 - plugins defined with webpack 3 _modules Set in a develope…

[alechill]

Plugins defined with webpack 3 Chunk._modules Set in a developer's parent project explode when run via webpack-dev-server, as dev-server actually starts and runs a webpack instance via its own dependency, which is currently 2.x . Bumping dependency to 3.x fixes this compatibility issue, and should be backwards compatible as the old modules array is deprecated gracefully.

What kind of change does this PR introduce?
Bug fix #947

Did you add or update the examples/?
N/A

Summary
Fixes #947

An upgrade to webpack 3 in own project broke webpack-dev-server controlled builds, breaking our workflow

CommonsChunkPlugin.js:289
for(const module of chunk.modulesIterable) {
^
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined

Does this PR introduce a breaking change?
Potentially due to peer dependency being bumped to a major version of webpack, may require its own major version altering to suit. Will let maintainers be the judge of that

Other information

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #956 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           4        4           
  Lines         463      463           
  Branches      139      139           
=======================================
  Hits          334      334           
  Misses        129      129

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcdca7...69098ee. Read the comment docs.

[lencioni]

Duplicate of #946

[shellscape]

indeed. resolved in 8978059