-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: scripts #1984
refactor: scripts #1984
Conversation
"build:client:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js", | ||
"build:client:live": "webpack ./client-src/live/index.js -o client/live.bundle.js --color --config client-src/live/webpack.config.js", | ||
"build:client:sockjs": "webpack ./client-src/sockjs/index.js -o client/sockjs.bundle.js --color --config client-src/sockjs/webpack.config.js", | ||
"build:client": "rimraf ./client/* && npm-run-all -s -l -p \"build:client:**\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We don't extract
rm
scripts because it doesn't have sense, nobody will be used their separate likenpm run rm:ssl
- We use
build:client
because we should migrate onbabel
in next major release for server, so we have these commands:
npm run build:client - build client
npm run build:server - build server (in next major release when we migrate on babel)
npm run build - build client and server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use babel at the server? we support Node6, 4, etc..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using all the features ES like async/await (already supported in node@8), private fields, import
/export
and etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not high priority but will be great to have consistent ecma 2018/2019 code in client and server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I hope to want to use typescript.😉 I need types..lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Node 6 was being dropped so we could use async/await, etc. without problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESM is not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ESM is not supported, it doesn't matter if we only use babel or typescript we will build server so i rename this command, approve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, approved
b5f885e
to
c045795
Compare
Sometimes our tests are freeze we need investigate this |
Codecov Report
@@ Coverage Diff @@
## master #1984 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 28 28
Lines 1075 1075
Branches 322 322
=======================================
Hits 992 992
Misses 79 79
Partials 4 4 Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
no required
Motivation / Use-Case
refactor
Breaking Changes
no
Additional Info
no