Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: allow comma-dangle in eslintrc because compete with prettier #1649

Merged
merged 1 commit into from
Feb 5, 2019
Merged

style: allow comma-dangle in eslintrc because compete with prettier #1649

merged 1 commit into from
Feb 5, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Feb 4, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Related to #1647 (comment)

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #1649 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1649      +/-   ##
==========================================
+ Coverage   75.14%   75.29%   +0.14%     
==========================================
  Files          10       10              
  Lines         688      688              
==========================================
+ Hits          517      518       +1     
+ Misses        171      170       -1
Impacted Files Coverage Δ
bin/utils.js 44.44% <ø> (ø) ⬆️
lib/Server.js 81.77% <ø> (+0.26%) ⬆️
bin/options.js 100% <ø> (ø) ⬆️
bin/webpack-dev-server.js 58.28% <ø> (ø) ⬆️
lib/utils/addEntries.js 100% <ø> (ø) ⬆️
examples/cli/public/webpack.config.js 100% <ø> (ø) ⬆️
lib/utils/createDomain.js 100% <ø> (ø) ⬆️
examples/util.js 81.81% <ø> (ø) ⬆️
lib/utils/createLogger.js 87.5% <ø> (ø) ⬆️
lib/utils/createCertificate.js 100% <ø> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04864...bed6c88. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my carelessness 😞

@alexander-akait alexander-akait merged commit 102941f into webpack:master Feb 5, 2019
@alexander-akait
Copy link
Member

@hiroppy what about migrate on jest?

@hiroppy hiroppy deleted the feature/modify-prettier branch February 5, 2019 08:01
@hiroppy
Copy link
Member Author

hiroppy commented Feb 5, 2019

np, thanks for your review!

yep, I agree with you. I'll migrate to jest from mocha:)

@alexander-akait
Copy link
Member

@hiroppy thanks for helping 👍

@hiroppy hiroppy mentioned this pull request Feb 5, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants