Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live bundle not loading, typo during migration #1329

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Live bundle not loading, typo during migration #1329

merged 1 commit into from
Mar 1, 2018

Conversation

mtraynham
Copy link
Contributor

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Nope, is typo.

Motivation / Use-Case

The live client was refactored and migrated from the pug-loader to the html-loader. The pug-loader, I assume, returns a function, whereas the html-loader returns a string.

You get this abstract error and the page completely fails to load:

jQuery.Deferred exception: n(...) is not a function TypeError: n(...) is not a function
    at HTMLDocument.<anonymous> (http://0.0.0.0:3000/__webpack_dev_server__/live.bundle.js:1:163209)
    at c (http://0.0.0.0:3000/__webpack_dev_server__/live.bundle.js:1:105849)
    at l (http://0.0.0.0:3000/__webpack_dev_server__/live.bundle.js:1:106151) undefined

@jsf-clabot
Copy link

jsf-clabot commented Mar 1, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #1329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files           6        6           
  Lines         494      494           
  Branches      160      160           
=======================================
  Hits          391      391           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94398c4...691de8e. Read the comment docs.

@SpaceK33z SpaceK33z merged commit f2db057 into webpack:master Mar 1, 2018
@SpaceK33z
Copy link
Member

Thanks for the PR and your clear explanation of what went wrong :).

@mtraynham
Copy link
Contributor Author

@SpaceK33z yw. Do you guys plan on a version bump soon? This is the last little thing I have before migrating to Webpackv4.

@SpaceK33z
Copy link
Member

Wasn't the plan, but I can do one tomorrow earliest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants