Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use worker from plugin and remove default #2340

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
yes

Summary

  • removes default sw which is no longer used, instead we injest sw using workbox plugin in webpack build chain

Does this PR introduce a breaking change?
no

Other information
no

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #2340 (6d71a3c) into master (ffc93e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2340   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files          51       51           
  Lines        2053     2053           
  Branches      506      506           
=======================================
  Hits         1400     1400           
  Misses        653      653           
Impacted Files Coverage Δ
packages/generators/src/init-generator.ts 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc93e5...6d71a3c. Read the comment docs.

@alexander-akait alexander-akait merged commit 9100137 into webpack:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants