Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Uprev crypto-browserify to latest #28

Closed
wants to merge 1 commit into from
Closed

Uprev crypto-browserify to latest #28

wants to merge 1 commit into from

Conversation

squirrelsama
Copy link

The current referenced version of crypto-browserify does not have support for new stream methods of hash functions, e.g.

var h = crypto.createHash('sha1'); 
h.write('a');
h.end('b');
h.read();

As a result, using webpack to pack the node-rsa package, for example, causes an error to occur as node-rsa is using the new stream support.

Please uprev the referenced version of crypto-browserify, as per this PR.

@squirrelsama
Copy link
Author

Heh. I just saw #19

Do we know whether the issue persists with 3.9.14?

spalger pushed a commit to spalger/kibana that referenced this pull request Jun 30, 2015
@nickdima
Copy link

nickdima commented Jul 3, 2015

@squirrelsama I just tried your fork and yes, the issue seems to still be there.

@sokra
Copy link
Member

sokra commented Aug 10, 2015

Can someone vertify if #19 is fixed?

@philikon
Copy link
Contributor

Ping?

philikon added a commit to philikon/node-libs-browser that referenced this pull request Oct 29, 2015
@sokra sokra closed this Dec 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants