-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncMFS for getBundleDirFromCompiler #275
Add AsyncMFS for getBundleDirFromCompiler #275
Conversation
I'll close and reopen the PR to trigger the CLA check again EDIT: Yup, it worked and the CLA status went green. |
As I said in #274, I think this is an OK tradeoff. I'm a bit wary on adding new configuration options as each new option makes the library a bit more difficult to use. Could we add a comment above the |
Sure! I have added comment mentioning usage of |
Hi @valscion, One of the travis-ci test is failing in Node.js 6 environment with
This appear to be an test environment issue, since the 2 additional commits dont change the behaviour of the code. Is it possible to restart the test? |
Done, and CI is still green. I'll let @th0r take a look at this PR to see if he's on the same page with me regarding this — if I don't hear from him in a few days I'll merge this PR as-is. Thank you for your contributions! |
Merged, but we need to think about some better solution. Maybe we can just use |
Published in |
Details
AsyncMFS
to support dev-server of Nuxt 2.5 and aboveRelated issues