-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependencies #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very nice! The only suggestion is to make "@babel/runtime" a strict dependency as all other dev dependencies. |
The miimal size saving is not worth the extra dependencies
@th0r Ups, that wasn't intentional. Fixed. |
Thanks a lot! |
Released in |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the v3 release, the new output is much cleaner. Great work!
I noticed v3 pulls in a few new dependencies that aren't necessary. This PR fixes that.
@babel/polyfill
,mobx
andmobx-preact
. Also fixes Missingpreact
dependency? #208.@babel/runtime
for the plugin itself (it stays around for the client). It only loaded four functions from the runtime (all related to ESM support) but brings in heavy dependencies.^
for the dependency onlodash
. It was the only one that didn't have it.