Add sass-embedded to default implementations #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please accept CLA and add test case, I fine with this |
|
CLA accepted, what test cases should I add? Cant find any tests for getDefaultSassImplementation(). Or you need some test repository where this fix applied? |
Codecov Report
@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 94.59% 93.83% -0.77%
==========================================
Files 5 5
Lines 370 373 +3
Branches 138 138
==========================================
Hits 350 350
- Misses 18 21 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
I will add test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Add sass-embedded to default implementations:
While using create-react-app and react-app-rewired I want to use sass-embedded, but config-overrides doesn
t work as expected: scssLoader.options.implementation = require('sass-embedded'); doesnt apply, I`m getting errors like "sass not found". So the easiest way to fix this is to add sass-embedded to getDefaultSassImplementation function.P.S. Idk if it is a bugfix or feature :D