ci: fix typo in lint matrix setup #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`env.node-version` was undefined (`matrix.node-version` was defined, but never used), therefore the linting used to run in Node.js 14
|
Oh, it seems the same typo has also made its way to the following:
Is this coming from some template? Or should I open a new PR in each of those? |
.github/workflows/nodejs.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| node-version: [12.x] | |||
| node-version: [14.x] | |||
There was a problem hiding this comment.
Don't change it, we use 12, i.e. minimum LTS for linting
There was a problem hiding this comment.
OK, the intent wasn't clear there - it was running in 14 up till now, though. Updated: 6dda685
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 97.04% 97.04%
=======================================
Files 5 5
Lines 271 271
Branches 88 88
=======================================
Hits 263 263
Misses 8 8 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
env.node-versionwas undefined (matrix.node-versionwas defined, but never used), therefore the linting used to run in Node.js 14This trips up my tools which scan which node versions are used in Github workflows :)
Breaking Changes
None
Additional Info
N/A