Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for empty descriptions #939

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

vhenzl
Copy link
Contributor

@vhenzl vhenzl commented Sep 14, 2021

See graphql/graphql-js#2177

Depends on #938.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #939 (4f4a635) into master (4ff4d52) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4f4a635 differs from pull request most recent head 840a9e6. Consider uploading reports for the commit 840a9e6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #939      +/-   ##
============================================
- Coverage     94.23%   94.22%   -0.01%     
  Complexity       50       50              
============================================
  Files           117      117              
  Lines          9679     9670       -9     
============================================
- Hits           9121     9112       -9     
  Misses          558      558              
Impacted Files Coverage Δ
src/Language/BlockString.php 100.00% <100.00%> (ø)
src/Language/Printer.php 99.25% <100.00%> (ø)
src/Utils/ASTDefinitionBuilder.php 90.00% <100.00%> (ø)
src/Utils/SchemaPrinter.php 98.94% <100.00%> (-0.03%) ⬇️
src/Error/Error.php 94.84% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff4d52...840a9e6. Read the comment docs.

@spawnia
Copy link
Collaborator

spawnia commented Sep 30, 2021

Ready to go, since #938 is merged?

@vhenzl vhenzl force-pushed the blockstring-empty-description branch from 4f4a635 to d809578 Compare October 1, 2021 07:53
@vhenzl vhenzl marked this pull request as ready for review October 1, 2021 07:55
@vhenzl
Copy link
Contributor Author

vhenzl commented Oct 1, 2021

Ready to go.

@spawnia spawnia merged commit 10419b0 into webonyx:master Oct 1, 2021
@vhenzl
Copy link
Contributor Author

vhenzl commented Oct 1, 2021

@spawnia Could these rules like "multiline ternary" be enforced by the linter?

@simPod
Copy link
Collaborator

simPod commented Oct 1, 2021

I'll set it up.

@vhenzl vhenzl deleted the blockstring-empty-description branch October 1, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants