Extract ODF field highlighting into standalone view #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. |
|
Thanks for the quick implementation. Not yet thrilled by it, but then that is hard to achieve ;) |
|
a changelog.md inside this PR might be nice, still :) |
As per design discussed in issue webodf#816. Extracting this into a separate view makes it optional for consumers to use (or potentially further customize). Fixes webodf#816.
peitschie
force-pushed
the
odf-field-view
branch
from
5c04714 to
018448d
Compare
|
Build succeeded. |
|
|
peitschie
added a commit
that referenced
this pull request
Sep 17, 2014
Extract ODF field highlighting into standalone view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per design discussed in issue #816. Extracting this into a separate view makes it optional for consumers to use (or potentially further customize).
Fixes #816.
For reviewers, the best way to review this is with the visual tests document: http://localhost:8124/programs/editor/src-localeditor.html#../../webodf/tests/visual-tests.fodt