Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Compilation.finish and setPreference #46

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Remove Compilation.finish and setPreference #46

merged 1 commit into from
Feb 27, 2020

Conversation

huningxin
Copy link
Contributor

@huningxin huningxin commented Feb 26, 2020 •
edited by pr-preview bot
Loading

fix #39

Preview | Diff

@huningxin
Copy link
Contributor Author

I am creating this PR based on RESOLUTION of Feb 20 CG meeting that

RESOLUTION: Refactor into createCompilation(CompilationPreference preference) and createExecution()

@wchao1115 @BenjaminPoulain @RafaelCintron @gramalingam, please take a look. Thanks!

@huningxin huningxin mentioned this pull request Feb 26, 2020
Closed
@huningxin
Copy link
Contributor Author

@wchao1115 , thanks for review and approval. I am going to merge it.

@huningxin huningxin merged commit d11c07f into webmachinelearning:master Feb 27, 2020
This was referenced Feb 27, 2020
Closed
Merged
@huningxin huningxin mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchao1115 wchao1115 wchao1115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Compilation.finish and setPreference
2 participants
@huningxin @wchao1115