[WIP] Make axis definition of concat and split consistent #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssiko
approved these changes
Feb 23, 2023
huningxin
changed the title
|
I mark this PR as WIP because there is on-going discussion on #345 . You are encouraged to share your thoughts in that issue. Once the consensus made, I'll update this PR and resume the review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #345
The current axis definitions of
concatandsplitare inconsistent. The difference is captured in the following table in #307, thanks @BruceDai !axisis the second parameteraxisis an option of the optional options parameterThis PR fixes this inconsistency by aligning the valid value range [-N, N) and negative value interpretation.
@wchao1115 @wacky6 @anssiko @RafaelCintron @pyu10055 , PTAL. Thanks!
Preview | Diff