New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement where #56

Merged

huningxin merged 7 commits into webmachinelearning:main from Mei0211:add_where

Nov 28, 2023

Mei0211 commented Nov 21, 2023

@BruceDai @huningxin @fdwr @mingmingtasd PTAL, thanks.

mei1127 added 2 commits

November 21, 2023 16:26


          Implement where

cec9e70


          modified the format of where_test.js

337b0f6

BruceDai reviewed

View reviewed changes

Contributor

BruceDai left a comment

Thanks @Mei0211!
And I have some comments, please have a look.

src/where.js Show resolved Hide resolved

test/where_test.js Show resolved Hide resolved


          modified where.js and where_test.js

9aa625d

BruceDai reviewed

View reviewed changes

test/where_test.js Outdated Show resolved Hide resolved


          modified where_test.js

afdb4c7

BruceDai reviewed

View reviewed changes

src/expand.js Outdated Show resolved Hide resolved

BruceDai reviewed

View reviewed changes

src/expand.js Outdated Show resolved Hide resolved

BruceDai reviewed

View reviewed changes

test/expand_test.js Outdated Show resolved Hide resolved

BruceDai reviewed

View reviewed changes

test/expand_test.js Outdated Show resolved Hide resolved

Mei0211 force-pushed the add_where branch from b7a8559 to afdb4c7 Compare

November 22, 2023 08:14

BruceDai mentioned this pull request

Add support for operations needed for well-known transformers e.g. Segment Anything, Stable Diffusion, etc. webmachinelearning/webnn#478

Merged

huningxin reviewed

View reviewed changes

Contributor

huningxin left a comment

Thanks for your contribution @Mei0211 !

src/where.js Outdated Show resolved Hide resolved

src/where.js Outdated Show resolved Hide resolved

src/where.js Outdated Show resolved Hide resolved

src/where.js Outdated Show resolved Hide resolved

test/where_test.js Show resolved Hide resolved

fdwr reviewed

View reviewed changes

fdwr left a comment

LGTM barring comments. Thanks for adding the conditional selection operator Mei.

src/where.js Outdated Show resolved Hide resolved

test/where_test.js Show resolved Hide resolved

mei1127 added 2 commits

November 27, 2023 15:08


          modified where.js and where_test.js

cee6d20

Please enter the commit message for your changes. Lines starting


          modified where.js

2d3f47f

BruceDai reviewed

View reviewed changes

src/where.js Outdated Show resolved Hide resolved


          modified where.js

377098b

Contributor

BruceDai commented Nov 27, 2023

@Mei0211 Thanks for your update, LGTM.

huningxin merged commit fd4d5af into webmachinelearning:main

fdwr reviewed

View reviewed changes

src/where.js

+               */
+              export function where(condition, trueValues, falseValues) {
+                const trueValuesReshape = trueValues.shape.length === 0 ?
+                  new Scalar(trueValues.data) :trueValues;

fdwr Nov 29, 2023 •

edited

Loading

Suggested change

      
                new Scalar(trueValues.data) :trueValues;
          
                new Scalar(trueValues.data) : trueValues;

Nit for when you touch this file in the future...

huningxin mentioned this pull request

Implement webnn-baseline and WPT for operations needed for well-known transformers webmachinelearning/webnn#485

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet