-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using wby-
Prefix With Tailwind CSS Classes
#4500
Open
adrians5j
wants to merge
25
commits into
feat/new-admin-ui
Choose a base branch
from
feat/wby-css-class-prefixing
base: feat/new-admin-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+767
−686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the base branch from
next
to
merge/next-to-new-admin-ui-2025-01-21
January 21, 2025 12:38
…feat/wby-css-class-prefixing
adrians5j
changed the title
Feat/wby css class prefixing
Using Jan 21, 2025
wby-
Prefix With Tailwind CSS Classes
…feat/wby-css-class-prefixing
…s-class-prefixing
…feat/wby-css-class-prefixing
…feat/wby-css-class-prefixing # Conflicts: # packages/admin-ui/src/Avatar/Avatar.tsx # packages/admin-ui/src/Checkbox/CheckboxPrimitive.tsx # packages/admin-ui/src/Dialog/components/DialogHeader.tsx # packages/admin-ui/src/DropdownMenu/DropdownMenu.tsx # packages/admin-ui/src/FormComponent/Label.tsx # packages/admin-ui/src/Icon/Icon.tsx # packages/admin-ui/src/Input/InputPrimitive.tsx # packages/admin-ui/src/Label/Label.tsx # packages/admin-ui/src/Select/SelectPrimitive.tsx # packages/admin-ui/src/Tabs/Tabs.tsx # packages/admin-ui/src/Textarea/TextareaPrimitive.tsx # packages/admin-ui/src/Tooltip/Tooltip.tsx
…into feat/wby-css-class-prefixing
adrians5j
changed the base branch from
merge/next-to-new-admin-ui-2025-01-21
to
feat/new-admin-ui
January 23, 2025 04:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we're prefixing all Tailwind classes with the
wby-
prefix.This way we're ensuring that, if users decided to use Tailwind in the Admin app, we don't prevent them from doing so.