Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up types #325

Merged
merged 5 commits into from
Dec 12, 2023
Merged

refactor: clean up types #325

merged 5 commits into from
Dec 12, 2023

Conversation

goosewobbler
Copy link
Member

@goosewobbler goosewobbler commented Dec 10, 2023

Cleaning up a load of types, especially around the CJS entry point files as they haven't been kept up to date with recent ESM changes.

@goosewobbler goosewobbler added the WIP Work in progress label Dec 10, 2023
@goosewobbler goosewobbler removed the WIP Work in progress label Dec 12, 2023
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goosewobbler goosewobbler merged commit f44b917 into main Dec 12, 2023
@goosewobbler goosewobbler deleted the sm/types-refactor branch December 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants