Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.lovoo.com - design is broken #14615

Closed
webcompat-bot opened this issue Jan 2, 2018 · 12 comments
Closed

www.lovoo.com - design is broken #14615

webcompat-bot opened this issue Jan 2, 2018 · 12 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-js Generic JS issues
Milestone

Comments

@webcompat-bot
Copy link

URL: https://www.lovoo.com/

Browser / Version: Firefox Mobile 59.0
Operating System: Android 8.1.0
Tested Another Browser: No

Problem type: Design is broken
Description: chat window is unusable, and profiles are buggy
Steps to Reproduce:

From webcompat.com with ❤️

@MDTsai
Copy link

MDTsai commented Jan 3, 2018

Design is the same for me using Chrome/Firefox mobile. There is one error message while click chat:

Error: e.response is undefined
a@https://webassets.lovoo.com/js/lovoo.min.js?1513870906374:1:277734
d/</k[o]/S<@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:483394
s/<@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:359839
$eval@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:367149
$digest@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:365706
$apply@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:367445
m/<@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:344140
g@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:345535
pt/</w.onload@https://webassets.lovoo.com/js/external.min.js?1513870906374:1:346081

@softvision-sergiulogigan

Well, this is something interesting...
It seems that when using the Chat and sending a message, you get logged out.
screen capture video1

Console says:
image

@karlcow
Copy link
Member

karlcow commented Aug 22, 2018

when POSTING The message we get

HTTP/2.0 403 Forbidden
date: Wed, 22 Aug 2018 04:50:49 GMT
content-type: application/json; charset=utf-8
content-length: 2
cache-control: max-age=0, must-revalidate, no-cache, no-store, private
set-cookie: lovoo=; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT; domain=.lovoo.com; secure; httponly
lovoocsrf=; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT; domain=.lovoo.com; secure
LooCoo=; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT; domain=.lovoo.com; secure; httponly
lovoo=; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT; secure; httponly
via: 1.1 google
alt-svc: clear
strict-transport-security: max-age=15552000
x-content-type-options: nosniff
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
server: cloudflare
cf-ray: 44e2b87fcc7d9481-NRT
X-Firefox-Spdy: h2

The POST data were

{"text":"test me what is happening","userId":"5473043ccd6da1f4618b4595"}

and the request

POST /api/users/5473043ccd6da1f4618b4595/write HTTP/1.1
Host: www.lovoo.com
User-Agent: Mozilla/5.0 (Android 7.0.0; Mobile; rv:62.0) Gecko/62.0 Firefox/62.0
Accept: application/json, text/plain, */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Referer: https://www.lovoo.com/list/liked-you
APP: lovoo
Content-Type: application/json;charset=utf-8
X-Csrf-Token: wQAhAYAdNPtVvnHSJysY6950
Content-Length: 72
Connection: keep-alive
Cookie: ****

and it's not about the user agent.

@softvision-sergiulogigan did it work for you on Chrome?

@softvision-sergiulogigan

Hey @karlcow

Tested on Samsung Galaxy S6, Android 7.0, 1440 x 2560 pixels (~577 ppi pixel density).
On Nightly with Chrome UA, the Logout action is still performed after sending a message.
On Chrome, on the other hand, no Logout action is performed after sending a message.

Chrome 68:
image

@karlcow
Copy link
Member

karlcow commented Aug 28, 2018

ah on Chrome I get a 403 too with exactly the same type of request and response.
So it is really done to how the response is handled by each browser.

@karlcow
Copy link
Member

karlcow commented Aug 28, 2018

fwiw this is happening on firefox desktop too.

@karlcow
Copy link
Member

karlcow commented Aug 28, 2018

I'm also suspicious about this error message

reCAPTCHA couldn't find user-provided function: vcRecaptchaApiLoaded
<script async type="text/javascript" src="https://www.google.com/recaptcha/api.js?onload=vcRecaptchaApiLoaded&render=explicit&hl=en"></script>

This should probably be rewritten as

<script async type="text/javascript" src="https://www.google.com/recaptcha/api.js?onload=vcRecaptchaApiLoaded()&render=explicit&hl=en"></script>

aka vcRecaptchaApiLoaded() instead of vcRecaptchaApiLoaded.

but probably not related to our issue. :/

@karlcow karlcow added the status-needsinfo-denschub ping @denschub label Aug 28, 2018
@karlcow
Copy link
Member

karlcow commented Aug 28, 2018

@denschub an idea?

@miketaylr miketaylr added the severity-important A non-core broken piece of functionality, not behaving the way you would expect. label Sep 13, 2018
@karlcow karlcow self-assigned this Feb 19, 2019
@karlcow karlcow removed the status-needsinfo-denschub ping @denschub label Feb 19, 2019
@karlcow
Copy link
Member

karlcow commented Feb 19, 2019

Taking another shot.

lovoo is coded with angular. I checked if there was something about vcRecaptchaApiLoaded
And I found that some people had the same issue.

and indeed the solution to this is the one in my previous comment

<textarea
  messenger-textarea=""
  content="selectedConversation.newMessageContent"
  on-first-char="firstCharTyped()"
  on-change-height="changedTextareaHeight(height)"
  on-enter="pressedEnterInTextarea()"
  max-rows="5"
  rows="1"
  class="small padding no-border full-width overflow-y-hidden"
  ng-class="{'bg-body': !selectedConversation.requestHelper.messages.isLoaded}"
  ng-disabled="!selectedConversation.requestHelper.messages.isLoaded"
  placeholder="Ton message"
  data-automation-id="new-chat-message-textarea"
  style="height: 39px;"
>
</textarea>

capture d ecran 2019-02-19 a 15 22 18

Let's see on Chrome.
capture d ecran 2019-02-19 a 15 43 46

So I guess this is not working in Chrome too.
The only difference is that it doesn't log out and it doesn't try to redirect to the home page.

to note that the URI at the top is
https://www.lovoo.com/welcome/login

Also funny thing, my interactions with the site seems to work better in general in Firefox than in Chrome. I got logged out during one interactions with Chrome too.

            responseError: function (n) {
              var l,
              c;
              if (0 === n.status) return n;
              if (403 === n.status && 'Forbidden' === n.statusText || n.access_denied) return a.location.href = o.Ajax.url + '/?show_login=true';
              if (429 === n.status && n.data) {
                var d = t.get('DialogService');
                return void d.openHtml(n.data)
              }

We are in the case of

 if (403 === n.status && 'Forbidden' === n.statusText || n.access_denied) return a.location.href = o.Ajax.url + '/?show_login=true';

And this is the part which is activated when we send a message

        o.sendMessage = function () {
          if (u.reinitialise(), !o.selectedConversation.sendMessage()) return;
          g = !1,
          o.$broadcast('messenger-textarea-focus'),
          o.selectedConversation.isRequest && function () {
            if (!o.selectedConversation.isRequest) return;
            var e = o.conversationLists.request.conversations.indexOf(o.selectedConversation);
            o.conversationLists.request.conversations.splice(e, 1),
            o.selectedConversation.isRequest = !1,
            _.each(o.conversationLists.active.conversations, function (e) {
              e.isSelected = !1
            }),
            o.conversationLists.active.conversations.unshift(o.selectedConversation),
            o.selectConversationList('active'),
            v(!1)
          }()
        },

and this is probably happening here

          if (u.reinitialise(), !o.selectedConversation.sendMessage()) return;

let's move this to needscontact.

@karlcow karlcow added the type-js Generic JS issues label Feb 19, 2019
@karlcow karlcow modified the milestones: needsdiagnosis, needscontact Feb 19, 2019
@karlcow
Copy link
Member

karlcow commented Feb 19, 2019

and fwiw this is not mobile only. This is happening on Desktop too.

@karlcow karlcow removed their assignment Feb 19, 2019
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@softvision-sergiulogigan

This is still happening.

Tested with:
Browser / Version: Firefox Preview Nightly 191031 (🦎: 72.0a1-20191029093803)
Operating System: Samsung Galaxy S8 (Android 9) - 1440 x 2960 pixels, 18.5:9 ratio (~570 ppi density)

@cipriansv cipriansv modified the milestones: needscontact, fixed Aug 25, 2020
@cipriansv
Copy link

After retesting the issue I confirm that the issue has been fixed.

After sending a text message you are nor logged out, you receive a prompt containing a message.

2020-08-25 15 32 45

Tested with:
Browser / Version: Firefox Nightly 200824(🦎 81.0a1-20200820093209)
Operating System: OnePlus6 (Android 10) - 1080 x 2280 pixels (~402 ppi pixel density)

Closing the issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-js Generic JS issues
Projects
None yet
Development

No branches or pull requests

6 participants