[NEU-146] Replace connectComponent with hooks (3) #830

dotrongkhang2000 · 2022-03-16T09:03:23Z

No description provided.

linear · 2022-03-16T09:03:26Z

NEU-146 Replace connectComponent with hooks

src/components/display-media/index.js

quanglam2807 · 2022-03-16T10:29:13Z

src/components/display-media/index.js

-  }
+const DisplayMedia = () => {
+  const classes = useStyles();
+  const [sources, setSource] = useState([]);


setSources, not setSource

…EU-146

src/components/display-media/index.js

quanglam2807

Re-check all dispatch implementations.

quanglam2807 · 2022-03-18T03:29:53Z

src/components/add-workspace/enhanced-dialog-title.js

-});
+}));
+
+const classes = useStyles();


Hooks must always be run inside React component function.

quanglam2807 · 2022-03-18T03:30:32Z

src/components/add-workspace/form.js

@@ -416,75 +417,15 @@ const AddWorkspaceCustom = ({
      </div>
      <Divider />
      <div className={classes.actions}>
-        <Button color="primary" variant="contained" disableElevation className={classes.button} onClick={onSave}>
+        <Button color="primary" variant="contained" disableElevation className={classes.button} onClick={dispatch(save)}>


Must be onClick={() => dispatch(save())

quanglam2807 · 2022-03-18T03:30:48Z

src/components/add-workspace/form.js

          Add
        </Button>
-        <Button color="default" variant="text" disableElevation className={classes.button} onClick={onResetForm}>
+        <Button color="default" variant="text" disableElevation className={classes.button} onClick={dispatch(resetForm)}>


Must be onClick={() => dispatch(resetForm())

quanglam2807 · 2022-03-18T03:31:34Z

src/components/app-lock/index.js

@@ -197,7 +199,7 @@ const AppLock = ({
              className={classes.unlockButton}
              startIcon={<LockIcon />}
              disableElevation
-              onClick={onValidateForm}
+              onClick={dispatch(validateForm)}


Must be onClick={() => dispatch(...

quanglam2807 · 2022-03-18T03:31:42Z

src/components/auth/index.js

+        />
+      </div>
+      <div>
+        <Button color="primary" variant="contained" disableElevation className={classes.button} onClick={dispatch(login)}>


quanglam2807 · 2022-03-18T03:31:52Z

src/components/go-to-url/index.js

+        />
+      </div>
+      <div>
+        <Button color="primary" variant="contained" disableElevation className={classes.button} onClick={dispatch(go())}>


Must be onClick={() => dispatch(...

quanglam2807 · 2022-03-18T03:32:02Z

src/components/license-registration/index.js

@@ -151,7 +151,7 @@ const DialogLicenseRegistration = ({
        </Button>
        <Button
          color="primary"
-          onClick={onRegister}
+          onClick={dispatch(register)}


register()

quanglam2807 · 2022-03-18T03:32:09Z

src/components/preferences/section-app-lock/dialog-app-lock.js

@@ -85,7 +85,7 @@ const DialogAppLock = ({

  return (
    <Dialog
-      onClose={onClose}
+      onClose={dispatch(close)}


quanglam2807 · 2022-03-18T03:32:19Z

src/components/preferences/section-app-lock/dialog-app-lock.js

@@ -182,7 +182,7 @@ const DialogAppLock = ({
        <div className={classes.actions}>
          <div className={classes.actionsLeft}>
            {hasPassword && !requireCurrentPassword && (
-              <Button variant="contained" disableElevation onClick={onDeletePassword}>
+              <Button variant="contained" disableElevation onClick={dispatch(deletePassword)}>


deletePassword()

quanglam2807 · 2022-03-18T03:35:07Z

src/components/add-workspace/form.js

+  const preferredIconType = useSelector((state) => state.dialogAddWorkspace.form.preferredIconType);
+  const shouldUseDarkColors = useSelector((state) => state.general.shouldUseDarkColors);
+  // eslint-disable-next-line max-len
+  const transparentBackground = useSelector((state) => Boolean(state.dialogAddWorkspace.form.transparentBackground));


Do not disable ESLINT rule. Instead try to make the code look nice.

useSelector( (state) => Boolean(state.dialogAddWorkspace.form.transparentBackground), );

quanglam2807 · 2022-03-18T03:37:02Z

src/components/preferences/section-app-lock/dialog-app-lock.js

@@ -202,15 +202,15 @@ const DialogAppLock = ({
            )}
          </div>
          <div className={classes.actionsRight}>
-            <Button variant="contained" className={classes.button} disableElevation onClick={onClose}>
+            <Button variant="contained" className={classes.button} disableElevation onClick={dispatch(close)}>


quanglam2807 · 2022-03-18T03:37:15Z

src/components/preferences/section-app-lock/dialog-app-lock.js

              Cancel
            </Button>
            {!requireCurrentPassword ? (
-              <Button color="primary" className={classes.button} variant="contained" disableElevation onClick={onSave}>
+              <Button color="primary" className={classes.button} variant="contained" disableElevation onClick={dispatch(save)}>


quanglam2807 · 2022-03-18T03:37:20Z

src/components/preferences/section-app-lock/dialog-app-lock.js

                Save
              </Button>
            ) : (
-              <Button color="primary" className={classes.button} variant="contained" disableElevation onClick={onValidateCurrentPassword}>
+              <Button color="primary" className={classes.button} variant="contained" disableElevation onClick={dispatch(validateCurrentPassword)}>


quanglam2807 · 2022-03-18T03:37:37Z

src/components/preferences/section-developers/index.js

+            />
+          </ListItemSecondaryAction>
+        </ListItem>
+        <ListItem button onClick={dispatch(openDialogCustomUserAgent)} disabled={forceMobileView}>


quanglam2807 · 2022-03-18T03:37:58Z

src/components/preferences/section-fonts/dialog-customize-fonts.js

-  save,
+  return (
+    <Dialog
+      onClose={dispatch(close)}


quanglam2807 · 2022-03-18T03:38:44Z

src/components/preferences/section-language/dialog-spellcheck-languages.js

          Cancel
        </Button>
-        <Button color="primary" variant="contained" disableElevation onClick={onSave}>
+        <Button color="primary" variant="contained" disableElevation onClick={dispatch(save)}>


src/components/preferences/section-language/index.js

quanglam2807 · 2022-03-18T03:38:59Z

src/components/preferences/section-link-handling/index.js

+      <List disablePadding dense>
+        <ListItemOpenProtocolUrl />
+        <Divider />
+        <ListItem button onClick={dispatch(openDialogExternallUrls)}>


src/components/preferences/section-link-handling/index.js

src/components/preferences/section-network/index.js

quanglam2807 · 2022-03-18T13:41:50Z

src/components/preferences/section-fonts/dialog-customize-fonts.js


-DialogCustomizeFonts.defaultProps = {
-  open: false,
-  defaultFontSize: 16,


defaultProps data is lost when moving to hooks

quanglam2807 · 2022-03-18T13:41:50Z

src/components/preferences/section-fonts/dialog-customize-fonts.js


-DialogCustomizeFonts.defaultProps = {
-  open: false,
-  defaultFontSize: 16,


defaultProps data is lost when moving to hooks

quanglam2807 · 2022-03-20T23:13:57Z

src/components/workspace-preferences/section-badge/index.js


 import { updateForm } from '../../../state/dialog-workspace-preferences/actions';

-const styles = (theme) => ({
+const usestyles = makeStyles((theme) => ({


useStyles not usestyles

dotrongkhang2000 added 5 commits March 15, 2022 16:00

[NEU-145] Add note about license key issuing policy in activation window

c92eb17

[NEU-145] Add note about license key issuing policy in activation window

0f13a4f

[NEU-145] Add note about license key issuing policy in activation window

d36642e

[NEU-145] Add note about license key issuing policy in activation window

4fd260d

[NEU-146] Replace connectComponent with hooks (3)

e2f8f8d

dotrongkhang2000 requested a review from quanglam2807 March 16, 2022 09:03

dotrongkhang2000 added 4 commits March 16, 2022 16:56

[NEU-146] Replace connectComponent with hooks (4)

bffb783

[NEU-146] Replace connectComponent with hooks (5)

1b71c43

[NEU-146] Replace connectComponent with hooks (6)

b047d45

[NEU-146] Replace connectComponent with hooks (7)

2fd7e4e

quanglam2807 suggested changes Mar 16, 2022

View reviewed changes

dotrongkhang2000 added 3 commits March 17, 2022 09:49

[NEU-146] Replace connectComponent with hooks (3)

d022c2b

Merge branch 'master' of https://github.com/webcatalog/neutron into N…

f23763b

…EU-146

delete code

0e4f248

quanglam2807 reviewed Mar 17, 2022

View reviewed changes

src/components/display-media/index.js Outdated Show resolved Hide resolved

quanglam2807 marked this pull request as draft March 17, 2022 04:29

dotrongkhang2000 added 13 commits March 17, 2022 12:46

[NEU-146] Replace connectComponent with hooks (8)

c22b544

[NEU-146] Replace connectComponent with hooks (9)

c55d7b5

[NEU-146] Replace connectComponent with hooks (10)

73ecc50

[NEU-146] Replace connectComponent with hooks (11)

6262d16

File 12

8bb5db6

File 13

d63c07a

File 14

0265856

File 15

939fcfc

File 16

8ad3ed2

File 17

c4e75a4

File 18

ef36074

File 19

07938b4

file 20

6213b5b

dotrongkhang2000 added 16 commits March 17, 2022 17:37

file 47

abec063

file 48

632598c

file 49

0c23232

file 50

07f5905

file 51

b1add7e

file 52

ff5a493

file 53

1fc771f

file 54

2966070

file 55

d10b181

file 56

10f15d6

file 57

6290ec5

file 58

674fb44

file 59

147c1c6

add array dependency

65ed1d8

file 60

360e464

update redux hooks

bb9dfdf

quanglam2807 marked this pull request as ready for review March 18, 2022 03:28

quanglam2807 reviewed Mar 18, 2022

View reviewed changes

quanglam2807 marked this pull request as draft March 18, 2022 03:40

quanglam2807 reviewed Mar 18, 2022

View reviewed changes

quanglam2807 reviewed Mar 20, 2022

View reviewed changes

dotrongkhang2000 added 3 commits March 21, 2022 15:11

fix disable ESLINT rule and dispatch implementations

89f1bc7

last refacetor redux

83f49b5

finish task

3371aee

quanglam2807 marked this pull request as ready for review March 22, 2022 04:24

quanglam2807 merged commit 662206d into master Mar 22, 2022

quanglam2807 deleted the NEU-146 branch March 22, 2022 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEU-146] Replace connectComponent with hooks (3) #830

[NEU-146] Replace connectComponent with hooks (3) #830

dotrongkhang2000 commented Mar 16, 2022

linear bot commented Mar 16, 2022

quanglam2807 Mar 16, 2022

quanglam2807 left a comment

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022 •

edited

Loading

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 18, 2022

quanglam2807 Mar 20, 2022

[NEU-146] Replace connectComponent with hooks (3) #830

[NEU-146] Replace connectComponent with hooks (3) #830

Conversation

dotrongkhang2000 commented Mar 16, 2022

linear bot commented Mar 16, 2022

Choose a reason for hiding this comment

quanglam2807 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quanglam2807 Mar 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quanglam2807 Mar 18, 2022 •

edited

Loading