Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Homography code and implement drawCorners method #15

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Oct 21, 2024

This pull request includes significant changes to the WebARKitCV project, focusing on enhancing the image processing capabilities and updating dependencies. The most important changes include adding new functions for drawing overlays, updating dependencies in package.json, and modifying the core classes to handle additional image data and keypoints.
Thus this PR try to implement the 2 point of issue #8.

Enhancements to image processing:

  • examples/example_image.html: Added functions createOverlayCanvas, clearOverlayCtx, drawCorners, and drawOverlay to handle overlay canvas creation and drawing. Updated event listener to use drawOverlay instead of transformElem. [1] [2]

Dependency updates:

  • package.json: Updated various development dependencies to their latest versions, including @babel/core, @babel/preset-env, @types/uuid, prettier, rimraf, ts-jest, typedoc, typescript, and webpack.

Modifications to core classes:

Refactoring and improvements:

@kalwalt kalwalt added 🚀 enhancement New feature or request 🔬 OpenCV Improvements to OpenCV code and building the source code labels Oct 21, 2024
@kalwalt kalwalt self-assigned this Oct 21, 2024
@kalwalt
Copy link
Member Author

kalwalt commented Dec 3, 2024

with the testing class WebARKItCOreCV2 i'am on the right path, at least we have a debug image in the example_image.html

@kalwalt
Copy link
Member Author

kalwalt commented Dec 4, 2024

The simple example example.html will not works because the imageData is not continuosly updated, until i will not improve that it worth to focus on other aspects.

@kalwalt
Copy link
Member Author

kalwalt commented Dec 6, 2024

with the commit 48bdfd6 the examople_image example doesn't works, I need to understand what bug was introduced...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 OpenCV Improvements to OpenCV code and building the source code 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant