-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves Homography code and implement drawCorners method #15
Open
kalwalt
wants to merge
14
commits into
dev
Choose a base branch
from
feat-improves-homography
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalwalt
added
🚀 enhancement
New feature or request
🔬 OpenCV
Improvements to OpenCV code and building the source code
labels
Oct 21, 2024
with the testing class WebARKItCOreCV2 i'am on the right path, at least we have a debug image in the |
The simple example example.html will not works because the imageData is not continuosly updated, until i will not improve that it worth to focus on other aspects. |
with the commit 48bdfd6 the examople_image example doesn't works, I need to understand what bug was introduced... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔬 OpenCV
Improvements to OpenCV code and building the source code
🚀 enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
WebARKitCV
project, focusing on enhancing the image processing capabilities and updating dependencies. The most important changes include adding new functions for drawing overlays, updating dependencies inpackage.json
, and modifying the core classes to handle additional image data and keypoints.Thus this PR try to implement the 2 point of issue #8.
Enhancements to image processing:
examples/example_image.html
: Added functionscreateOverlayCanvas
,clearOverlayCtx
,drawCorners
, anddrawOverlay
to handle overlay canvas creation and drawing. Updated event listener to usedrawOverlay
instead oftransformElem
. [1] [2]Dependency updates:
package.json
: Updated various development dependencies to their latest versions, including@babel/core
,@babel/preset-env
,@types/uuid
,prettier
,rimraf
,ts-jest
,typedoc
,typescript
, andwebpack
.Modifications to core classes:
src/Workers/WebARKitCVWorkers.ts
: Added logging and new variablescorners
andfinalImage
to thefound
method. Updated event dispatch to include these new details. [1] [2] [3]src/core/WebARKitCoreCV.ts
: Introduced new variablescorners_out
andgrayImage
. Modified methods to usegrayImage
for grayscale conversion and keypoint detection. Added logic to handle good matches and compute homography. [1] [2] [3] [4] [5] [6] [7] [8] [9]Refactoring and improvements:
src/Workers/Worker.ts
: Changed import fromWebARKitCoreCV
toWebARKitCoreCV2
.