-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disclaimer msgs #7446
disclaimer msgs #7446
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0c179b8 | Previous: bc4a34b | Ratio |
---|---|---|---|
processingTx |
23715 ops/sec (±6.14% ) |
21846 ops/sec (±6.96% ) |
0.92 |
processingContractDeploy |
38044 ops/sec (±12.13% ) |
39853 ops/sec (±7.71% ) |
1.05 |
processingContractMethodSend |
16586 ops/sec (±7.87% ) |
15980 ops/sec (±7.62% ) |
0.96 |
processingContractMethodCall |
28598 ops/sec (±6.28% ) |
27164 ops/sec (±8.09% ) |
0.95 |
abiEncode |
44617 ops/sec (±7.03% ) |
42205 ops/sec (±7.03% ) |
0.95 |
abiDecode |
29210 ops/sec (±7.58% ) |
30198 ops/sec (±6.77% ) |
1.03 |
sign |
1547 ops/sec (±0.81% ) |
1503 ops/sec (±3.45% ) |
0.97 |
verify |
369 ops/sec (±0.76% ) |
375 ops/sec (±0.43% ) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7446 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 218 218
Lines 8637 8637
Branches 2364 2364
=======================================
Hits 8166 8166
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
disclaimer msgs
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.