-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix padRight validation failure on large uint #7265
fix padRight validation failure on large uint #7265
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0f33f43 | Previous: d6baee6 | Ratio |
---|---|---|---|
processingTx |
22502 ops/sec (±7.20% ) |
20672 ops/sec (±7.40% ) |
0.92 |
processingContractDeploy |
38484 ops/sec (±5.62% ) |
39409 ops/sec (±5.84% ) |
1.02 |
processingContractMethodSend |
16043 ops/sec (±6.31% ) |
14911 ops/sec (±8.22% ) |
0.93 |
processingContractMethodCall |
27304 ops/sec (±5.87% ) |
26166 ops/sec (±9.05% ) |
0.96 |
abiEncode |
42863 ops/sec (±7.24% ) |
41338 ops/sec (±7.20% ) |
0.96 |
abiDecode |
29941 ops/sec (±7.18% ) |
29000 ops/sec (±6.11% ) |
0.97 |
sign |
1495 ops/sec (±3.48% ) |
1518 ops/sec (±3.68% ) |
1.02 |
verify |
366 ops/sec (±0.65% ) |
365 ops/sec (±0.65% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7265 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 216 216
Lines 8463 8463
Branches 2338 2339 +1
=======================================
Hits 7992 7992
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
…-that-begin-with-0x8-or-higher
Description
Fixes #7182
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.