This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix an issue with smart contract function overloading #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6922 +/- ##
==========================================
+ Coverage 87.37% 91.96% +4.58%
==========================================
Files 197 215 +18
Lines 7548 8197 +649
Branches 2059 2214 +155
==========================================
+ Hits 6595 7538 +943
+ Misses 953 659 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Muhammad-Altabba
requested review from
avkos,
jdevcs and
luu-alex
as code owners
| [methodAbi] = applicableMethodAbi; // take the first item that is the only item in the array | ||
| } else { | ||
| [methodAbi] = applicableMethodAbi; // take the first item in the array | ||
| // TODO: Should throw a new error with the list of methods found. |
There was a problem hiding this comment.
An issue has been created: #6923
The changes was not applied to not introduce a breaking change. If someone things this is an acceptable change in 4.x. We can discuss and probably implement.
jdevcs
approved these changes
Mar 25, 2024
jdevcs
reviewed
Mar 25, 2024
avkos
approved these changes
Mar 25, 2024
…s-is-running-method-with-string-signature
…s-is-running-method-with-string-signature
Muhammad-Altabba
deleted the
6837-contractmethodsfunctionnameaddressaddress-is-running-method-with-string-signature
branch
Merged
This was referenced Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6837
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.