Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Mar 24, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6837

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Mar 24, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 619.33 kB → 619.46 kB (+128 B) +0.02%
Changeset
File Δ Size
../web3-eth-contract/lib/commonjs/contract.js 📈 +1.13 kB (+2.97%) 38.07 kB → 39.2 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 600.27 kB → 600.39 kB (+128 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

github-actions bot commented Mar 24, 2024

Benchmark

Benchmark suite Current: 99d71dc Previous: 6c075db Ratio
processingTx 9138 ops/sec (±4.01%) 9301 ops/sec (±4.81%) 1.02
processingContractDeploy 39814 ops/sec (±6.94%) 39129 ops/sec (±7.62%) 0.98
processingContractMethodSend 19160 ops/sec (±6.58%) 19443 ops/sec (±5.19%) 1.01
processingContractMethodCall 37874 ops/sec (±5.80%) 38971 ops/sec (±6.34%) 1.03
abiEncode 42674 ops/sec (±7.85%) 44252 ops/sec (±6.92%) 1.04
abiDecode 29603 ops/sec (±7.69%) 30419 ops/sec (±8.89%) 1.03
sign 1559 ops/sec (±3.05%) 1656 ops/sec (±4.08%) 1.06
verify 374 ops/sec (±0.50%) 373 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Merging #6922 (004a5b5) into 4.x (4358140) will increase coverage by 4.58%.
Report is 210 commits behind head on 4.x.
The diff coverage is 100.00%.

❗ Current head 004a5b5 differs from pull request most recent head 99d71dc. Consider uploading reports for the commit 99d71dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6922      +/-   ##
==========================================
+ Coverage   87.37%   91.96%   +4.58%     
==========================================
  Files         197      215      +18     
  Lines        7548     8197     +649     
  Branches     2059     2214     +155     
==========================================
+ Hits         6595     7538     +943     
+ Misses        953      659     -294     
Flag Coverage Δ
UnitTests 91.96% <100.00%> (+4.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

[methodAbi] = applicableMethodAbi; // take the first item that is the only item in the array
} else {
[methodAbi] = applicableMethodAbi; // take the first item in the array
// TODO: Should throw a new error with the list of methods found.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue has been created: #6923
The changes was not applied to not introduce a breaking change. If someone things this is an acceptable change in 4.x. We can discuss and probably implement.

@Muhammad-Altabba Muhammad-Altabba merged commit 526c6f5 into 4.x Mar 27, 2024
16 of 18 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 6837-contractmethodsfunctionnameaddressaddress-is-running-method-with-string-signature branch March 27, 2024 02:23
Copy link

@Frank122480 Frank122480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contract.methods['functionName(address)'](address) is running method with string signature
4 participants