-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fix an issue with smart contract function overloading #6922
Fix an issue with smart contract function overloading #6922
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6922 +/- ##
==========================================
+ Coverage 87.37% 91.96% +4.58%
==========================================
Files 197 215 +18
Lines 7548 8197 +649
Branches 2059 2214 +155
==========================================
+ Hits 6595 7538 +943
+ Misses 953 659 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[methodAbi] = applicableMethodAbi; // take the first item that is the only item in the array | ||
} else { | ||
[methodAbi] = applicableMethodAbi; // take the first item in the array | ||
// TODO: Should throw a new error with the list of methods found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An issue has been created: #6923
The changes was not applied to not introduce a breaking change. If someone things this is an acceptable change in 4.x. We can discuss and probably implement.
…s-is-running-method-with-string-signature
…s-is-running-method-with-string-signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6837
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.