-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stress Tests 2 - QA Tests #6583
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6583 +/- ##
==========================================
+ Coverage 87.37% 89.54% +2.17%
==========================================
Files 197 215 +18
Lines 7548 8276 +728
Branches 2059 2242 +183
==========================================
+ Hits 6595 7411 +816
+ Misses 953 865 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just need above change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the review points t #6595 as it already contains the commits of this PR.
packages/web3/test/stress/index.js
Outdated
const c = new web3.eth.Contract(contractData.abi); | ||
const contract = await c.deploy(deployOptions).send(sendOptions); | ||
|
||
console.time(`Send huge data [${i}]`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here as shared in #6595 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, for improvements you can do in other wip Stress testing PR or followup PR/issue.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #5563
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.