-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Expose plugin functionality to plugins so it's easier to discover what plugins could do #6538
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6538 +/- ##
==========================================
+ Coverage 89.56% 89.65% +0.09%
==========================================
Files 215 215
Lines 8251 8237 -14
Branches 2234 2224 -10
==========================================
- Hits 7390 7385 -5
+ Misses 861 852 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also fix tests
packages/web3/test/integration/web3-plugin-add-tx.test.ts
and
packages/web3-eth-accounts/test/unit/tx/registerNewTx.test.ts
to use this new method registerNewTransactionType
Signed-off-by: Marin Petrunic <[email protected]>
Signed-off-by: Marin Petrunic <[email protected]>
Signed-off-by: Marin Petrunic <[email protected]>
Signed-off-by: Marin Petrunic <[email protected]>
bf9368b
to
2ed6b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Just a small comment I think was missed.
Co-authored-by: Muhammad Altabba <[email protected]>
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.