This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove the unnecessary chainId parameter (#5888) #6057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex <[email protected]> Co-authored-by: Wyatt Barnes <[email protected]> Co-authored-by: Junaid <[email protected]>
Pull Request Test Coverage Report for Build 4860810584
💛 - Coveralls |
All code changes in this PR are already approved in #5888 so merging in 1.x , Linting tests are not passing but its discussed in team meeting that we will go ahead with it as it will be fixed in next release auto ( due to cyclic deps ) |
This was referenced May 2, 2023
Merged
This was referenced Jun 1, 2023
This was referenced Sep 4, 2023
This was referenced Sep 18, 2023
This was referenced May 12, 2024
This was referenced May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created this PR for changelog update and e2ewin tests of #5888
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.