-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web3-eth-accounts.rst #5810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luu-alex for handling this community member MR.
Actually, to handle the fact that community members' MRs do not pass the pipeline checks, you could do the following (And I hope I am recalling the correct steps. And you could check this yourself):
- Create a new branch
- cherry-pick the commits from the original MR.
- Open an MR to merge your branch.
This way the history of the commits will be preserved 😄 . And if I could recall correctly, if you did not close the original MR and just kept it open. It will be automatically marked as "Merged" by GitHub after your MR got merged. This is because all the commits of the original MR will be indirectly merged through your MR.
@Muhammad-Altabba Thank you for the review :) |
@Muhammad-Altabba ah the pipelines do not run as no code was changed. This MR is still valid |
Description
#5674
This PR changes the examples from number to string, should be using number string instead of number
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.