Refactored the contract object #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
force-pushed
the
newContract
branch
from
5962333 to
94ea673
Compare
frozeman
force-pushed
the
newContract
branch
from
13bd3e8 to
721668d
Compare
frozeman
force-pushed
the
newContract
branch
from
c3de77f to
ee6f298
Compare
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* started contract * prepared the contract functions * added deploy function * added event emitter funcitons * eventified promise * added encodeABI * added optional bluebird * improved the param finder * added call, transact and estimateGas * allow siganture for encodeABI * working on events * added event listeners to contracts * working on contract events * changed on message to on data * working on decoding events * switched deploy check to subscriptions * removed all event functions, keep only contract.on * added subscription stuff * fixed substractions formatters * added log decoding * added all events * fixed events * added new method calling structure * added mined event for send tx * worked on getPastEvents, still WIP * working on tests * added once method * made options object in function execution optional * finished pastEvents * added request function for batch processing to contract methods * fixed contract tests * finished proting tests * test provider isolatiton issues * commented out test to prevent unsolvable issue for now * changed deploy resolve * deactivate encodeABI * improved fake provider, with stacking validation and results * added fromBlock test * added tests for internal methods of the contract object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the following: ethereum/EIPs#68