-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events sending
and sent
to tx submission, add arg latestBlockHash
to event confirmation
#3550
Conversation
add arg `latestBlockHash` to `confirmation`
fix folder name typo
sending
and sent
to transaction submission, add latestBlockHash
to confirmation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool! Just left a couple questions.
move 'sending' to after any intermediate requests
sending
and sent
to transaction submission, add latestBlockHash
to confirmation
sending
and sent
to tx submission, add arg latestBlockHash
to event confirmation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect to me 🎉
The payload object seems good. The formatting's raw which is good for seeing what actually gets sent over the wire.
An example from the deploy test:
{
"method": "eth_sendTransaction",
"params": [
{
"from": "0x4f861a99cf97d053ccb97f9fd5acd5ce2f570171",
"data": "0x6080604.....",
"gasPrice": "0x1",
"gas": "0x3d0900"
}
]
}
once( | ||
type: 'transactionHash', | ||
handler: (receipt: string) => void | ||
handler: (transactionHash: string) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice catch.
great, thanks! |
This PR:
sending
andsent
.confirmation
:latestBlockHash
.Fixes #3438
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build-all
and tested the resulting files fromdist
folder in a browser.CHANGELOG.md
file in the root folder.