Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for subscription.on(connected) #3326

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Add types for subscription.on(connected) #3326

merged 3 commits into from
Jan 22, 2020

Conversation

cgewecke
Copy link
Collaborator

Description

Adds type definition for the subscription 'connected' event.

Don't see a unit test verifying that the value passed to the connected callback is a string but I checked this manually and looks right.

Fixes #3319

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Jan 21, 2020

Coverage Status

Coverage remained the same at 85.445% when pulling d9ac8c1 on issue/3319 into 7386be2 on 1.x.

@nivida nivida added 1.x 1.0 related issues Types Incorrect or missing types labels Jan 22, 2020
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Test cases for the connected listener do exist in the PRI branch and should get merged soon ™.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing types for Subscription.on('connected')
4 participants