Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Bug #1123 #1135

Merged
merged 4 commits into from Oct 24, 2017
Merged

Fix for Bug #1123 #1135

merged 4 commits into from Oct 24, 2017

Conversation

dacarley
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 23, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 85.588% when pulling b106081 on blitzpredict:bug1123 into 78bdf99 on ethereum:1.0.

frozeman
frozeman approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@frozeman frozeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, great addition as well as the tests.

@frozeman frozeman merged commit f640061 into web3:1.0 Oct 24, 2017
@dacarley dacarley deleted the bug1123 branch October 24, 2017 19:21
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@dacarley @nachomazzara
Fix for Bug web3#1123 (web3#1135)
60cbdd4 
* Fix for Bug web3#1123

* Trigger travis

* Removed a bogus test for `bytes64`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacarley @coveralls @frozeman