Account signing fix

[frozeman]

This should fix the transaction signing for custom network IDs. Please test.

[coveralls]

Coverage increased (+0.03%) to 85.593% when pulling 2132923 on accountSigningFix into 2db8312 on 1.0.

[naddison36]

I would like to test this as I'm trying to sign locally before sending raw transaction to a remote node. What's the best way to get npm to install from this accountSigningFix branch?

[frozeman]

Use in your package json the the git branch rather than the version number: https://stackoverflow.com/questions/39732397/install-specific-branch-from-github-using-npm

[naddison36]

@frozeman I tried adding "web3": "git://github.com/ethereum/web3.js#accountSigningFix" to my package.json but I got the following error

npm ERR! Darwin 16.7.0
npm ERR! argv "/Users/nick/.nvm/versions/node/v6.11.4/bin/node" "/Users/nick/.nvm/versions/node/v6.11.4/bin/npm" "update"
npm ERR! node v6.11.4
npm ERR! npm  v3.10.10
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn

npm ERR! [email protected] postinstall: `lerna bootstrap`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] postinstall script 'lerna bootstrap'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the web3 package,
npm ERR! not with npm itself.

The latest version of the 1.0 branch installs fine "web3": "1.0.0-beta.23"

I seem to be missing something when installing from a branch. Does the branch need to be built?

[frozeman]

I updated the eth-lib version to 0.2.5 please re-test.

@naddison36 It should build fine, please check the npm-log, or lerna log for details on your side.

[coveralls]

Coverage increased (+0.03%) to 85.593% when pulling e47b8b5 on accountSigningFix into 2db8312 on 1.0.

[naddison36]

I'm still getting the same error. I've even tried the nuclear option of deleting my node_modules folder and npm cache.

This is the error in npm-debug.log

50149 verbose lifecycle [email protected]~postinstall: PATH: /Users/nick/.nvm/versions/node/v6.11.4/lib/node_modules/npm/bin/node-gyp-bin:/Users/nicholasaddison/Documents/workspaces/open-bank-token/node_modules/web3/node_modules/.bin:/Users/nick/Documents/workspaces/open-bank-token/node_modules/.bin:/Users/nick/.nvm/versions/node/v6.11.4/bin:/Users/nick/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
50150 verbose lifecycle [email protected]~postinstall: CWD: /Users/nick/Documents/workspaces/open-bank-token/node_modules/web3
50151 silly lifecycle [email protected]~postinstall: Args: [ '-c', 'lerna bootstrap' ]
50152 info lifecycle [email protected]~postinstall: Failed to exec postinstall script
50153 verbose unlock done using /Users/nick/.npm/_locks/staging-0ee530199745d5d9.lock for /Users/nick/Documents/workspaces/open-bank-token/node_modules/.staging
50154 silly rollbackFailedOptional Starting
50155 silly rollbackFailedOptional Finishing
50156 silly runTopLevelLifecycles Finishing
50157 silly install printInstalled
50158 verbose stack Error: [email protected] postinstall: `lerna bootstrap`
50158 verbose stack spawn ENOENT
50158 verbose stack     at ChildProcess.<anonymous> (/Users/nick/.nvm/versions/node/v6.11.4/lib/node_modules/npm/lib/utils/spawn.js:33:16)
50158 verbose stack     at emitTwo (events.js:106:13)
50158 verbose stack     at ChildProcess.emit (events.js:191:7)
50158 verbose stack     at maybeClose (internal/child_process.js:920:16)
50158 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:230:5)
50159 verbose pkgid [email protected]

I don't know where the lerna log is kept

[frozeman]

Could you try installing lerna globally before?

[coveralls]

Coverage increased (+0.03%) to 85.593% when pulling 1b0bb5d on accountSigningFix into 66e56b3 on 1.0.

[coveralls]

Coverage increased (+0.03%) to 85.593% when pulling 1b0bb5d on accountSigningFix into 66e56b3 on 1.0.

[coveralls]

Coverage increased (+0.03%) to 85.593% when pulling 1b0bb5d on accountSigningFix into 66e56b3 on 1.0.