Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in docs #4616

Closed
1 task done
chenxsan opened this issue Dec 10, 2021 · 0 comments · Fixed by #4599 or #4640
Closed
1 task done

A typo in docs #4616

chenxsan opened this issue Dec 10, 2021 · 0 comments · Fixed by #4599 or #4640
Labels
Bug Addressing a bug

Comments

@chenxsan
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently,

``Number|String|BN|BigNumber``(optional)

would render into:

image

A whitespace before the (optional) is needed to render it right.

Expected Behavior

``Number|String|BN|BigNumber``

renders into <code></code>.

Steps to Reproduce

Just check the doc page https://web3js.readthedocs.io/en/v1.5.2/web3-eth-contract.html#methods-mymethod-send

Web3.js Version

1.5.2

Environment

  • Operating System:
  • Browser:
  • Node.js Version:
  • NPM Version:

Anything Else?

No response
@chenxsan chenxsan added the Bug Addressing a bug label Dec 10, 2021
@chenxsan chenxsan mentioned this issue Dec 10, 2021
Merged
16 tasks
@luu-alex luu-alex linked a pull request Dec 14, 2021 that will close this issue
Fix a typo #4599
Merged
16 tasks
@nazarhussain nazarhussain mentioned this issue Dec 17, 2021
Merged
16 tasks
jdevcs pushed a commit that referenced this issue Dec 17, 2021
@nazarhussain @chenxsan
Fix a typo in docs #4616 (#4640)
8783f4d 
* Empty commit to trigger CI

* Fix a typo (#4599)

* Fix a typo

* update changelog

Co-authored-by: Nazar Hussain <[email protected]>

* 📝 Update the chanelog for 1.7.1

Co-authored-by: Sam Chen <[email protected]>
@sync-by-unito sync-by-unito bot mentioned this issue Feb 1, 2022
Closed
This was referenced Feb 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 24, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a typo chenxsan/web3.js
Fix a typo in docs #4616 web3/web3.js
1 participant
@chenxsan