Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all IDL files into interfaces/ #9892

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Consolidate all IDL files into interfaces/ #9892

merged 1 commit into from
Mar 8, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Mar 7, 2018 •
edited by wpt-pr-bot
Loading

Closes #9026.

@foolip foolip removed the request for review from chunywang March 7, 2018 04:50
@foolip foolip requested a review from lukebjerring March 7, 2018 04:50
@foolip
Copy link
Member Author

foolip commented Mar 7, 2018 •
edited
Loading

@lukebjerring, as an aside, this is another typical example where highlighting new test failures would be super helpful. If I've made a single typo here, some test might be broken entirely, and probably nobody would notice for a few weeks or months.

@ghost
Copy link

ghost commented Mar 7, 2018 •
edited by ghost
Loading

Build PASSED

Started: 2018-03-07 04:49:44
Finished: 2018-03-07 05:03:00

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

bsittler
bsittler reviewed Mar 8, 2018
View reviewed changes
Copy link
Contributor

@bsittler bsittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cookie-store parts look good to me

@foolip
Copy link
Member Author

foolip commented Mar 8, 2018

@jgraham can you rubber stamp? Or carefully review if you like :)

@wpt-pr-bot wpt-pr-bot requested a review from chunywang March 8, 2018 05:19
bsittler
bsittler approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@bsittler bsittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @foolip !

@bsittler bsittler merged commit 4a9668d into master Mar 8, 2018
@foolip foolip deleted the idl-in-interfaces branch March 8, 2018 05:30
@foolip
Copy link
Member Author

foolip commented Mar 8, 2018

@lukebjerring, can you rebase all the branches that have merge conflicts now? Should see some nice new diffs.

@lukebjerring
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsittler bsittler bsittler approved these changes

@aliams aliams Awaiting requested review from aliams

@annevk annevk Awaiting requested review from annevk

@apowers313 apowers313 Awaiting requested review from apowers313

@beverloo beverloo Awaiting requested review from beverloo

@ddorwin ddorwin Awaiting requested review from ddorwin

@dumbmatter dumbmatter Awaiting requested review from dumbmatter

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

@jakearchibald jakearchibald Awaiting requested review from jakearchibald

@jcjones jcjones Awaiting requested review from jcjones

@jdm jdm Awaiting requested review from jdm

@jensl jensl Awaiting requested review from jensl

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

@odinho odinho Awaiting requested review from odinho

@lukebjerring lukebjerring Awaiting requested review from lukebjerring

@chunywang chunywang Awaiting requested review from chunywang

Assignees
No one assigned
Labels
background-fetch cookie-store encrypted-media entries-api FileAPI IndexedDB interfaces storage webauthn wg-html wg-webapps wg-webauthn wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foolip @lukebjerring @bsittler @wpt-pr-bot