Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP: Implement 'prefetch-src' behind a flag. #9013

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 12, 2018

As discussed in w3c/webappsec-csp#107,
'prefetch-src' gives developers the ability to control the endpoints
from which resources may be prefetched.

Bug: 801561
Change-Id: Ifedd78e3101ea66d242c6f3c7a2f49385a681bd1
Reviewed-on: https://chromium-review.googlesource.com/864362
Commit-Queue: Mike West [email protected]
Reviewed-by: Yoav Weiss [email protected]
Cr-Commit-Position: refs/heads/master@{#529413}


This change is Reviewable

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@ghost
Copy link

ghost commented Jan 12, 2018

Build PASSED

Started: 2018-01-17 10:06:54
Finished: 2018-01-17 10:30:14

View more information about this build on:

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikewest added a commit to w3c/webappsec-csp that referenced this pull request Jan 15, 2018
@Hexcles
Copy link
Member

Hexcles commented Jan 15, 2018

@mikewest seems flaky on Firefox. 1/10 timeout, same after retry.

@mikewest
Copy link
Member

@yoavweiss: Do you know who at Mozilla might be able to give feedback on their prefetch implementation and what I could do to make it less flaky? :)

@yoavweiss
Copy link
Contributor

I'm not sure, but maybe @ddragana would know

@mikewest
Copy link
Member

The new test implementation looks more stable. Yay!

As discussed in w3c/webappsec-csp#107,
'prefetch-src' gives developers the ability to control the endpoints
from which resources may be prefetched.

Bug: 801561
Change-Id: Ifedd78e3101ea66d242c6f3c7a2f49385a681bd1
Reviewed-on: https://chromium-review.googlesource.com/864362
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/heads/master@{#529413}
@Hexcles
Copy link
Member

Hexcles commented Jan 16, 2018

Looks like a flake in the Travis infra blocked the merge. Restarted Travis and have my fingers crossed.

@mikewest
Copy link
Member

Hrm. The Travis check seems stalled: https://travis-ci.org/w3c/web-platform-tests/builds/329478528?utm_source=github_status&utm_medium=notification. Perhaps you could kick it again, @Hexcles? :)

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d2af033 into master Jan 17, 2018
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-864362 branch January 17, 2018 15:01
@Hexcles
Copy link
Member

Hexcles commented Jan 17, 2018

@mikewest Travis had an outage yesterday. It's now back online and the PR has been merged! :)

annevk pushed a commit to whatwg/fetch that referenced this pull request Apr 27, 2018
ryandel8834 added a commit to ryandel8834/WebAppSec-CSP that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants