-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSP: Implement 'prefetch-src' behind a flag. #9013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
Build PASSEDStarted: 2018-01-17 10:06:54 View more information about this build on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3006e85
to
455d8d0
Compare
Closes #107. Tests in web-platform-tests/wpt#9013.
@mikewest seems flaky on Firefox. 1/10 timeout, same after retry. |
@yoavweiss: Do you know who at Mozilla might be able to give feedback on their |
I'm not sure, but maybe @ddragana would know |
455d8d0
to
5fc8920
Compare
The new test implementation looks more stable. Yay! |
5fc8920
to
15b87f1
Compare
As discussed in w3c/webappsec-csp#107, 'prefetch-src' gives developers the ability to control the endpoints from which resources may be prefetched. Bug: 801561 Change-Id: Ifedd78e3101ea66d242c6f3c7a2f49385a681bd1 Reviewed-on: https://chromium-review.googlesource.com/864362 Commit-Queue: Mike West <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#529413}
15b87f1
to
7f4e4a2
Compare
Looks like a flake in the Travis infra blocked the merge. Restarted Travis and have my fingers crossed. |
Hrm. The Travis check seems stalled: https://travis-ci.org/w3c/web-platform-tests/builds/329478528?utm_source=github_status&utm_medium=notification. Perhaps you could kick it again, @Hexcles? :) |
@mikewest Travis had an outage yesterday. It's now back online and the PR has been merged! :) |
Corresponding CSP change: w3c/webappsec-csp#283. Tests: web-platform-tests/wpt#9013. Closes #658.
As discussed in w3c/webappsec-csp#107,
'prefetch-src' gives developers the ability to control the endpoints
from which resources may be prefetched.
Bug: 801561
Change-Id: Ifedd78e3101ea66d242c6f3c7a2f49385a681bd1
Reviewed-on: https://chromium-review.googlesource.com/864362
Commit-Queue: Mike West [email protected]
Reviewed-by: Yoav Weiss [email protected]
Cr-Commit-Position: refs/heads/master@{#529413}
This change is