Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Store API - Add tests for creation url, control characters, default secure #50129

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

RupinMittal
Copy link
Contributor

Added tests:

  1. Check that set/get/getAll are using the context's creation URL
  2. Check that set fails if certain control characters are present in the name or value
  3. Check that CookieListItem is secure by default (we want to test this property individually since the other tests in set_arguments check other properties first--so failing one of the earlier properties means we never check the secure property)

Changed tests:

  1. There are two tests in set_arguments and delete_arguments that pass in the result of get() to delete(). These tests indirectly depend on the domain property. But Safari/Mozilla don't support domain being returned by get(). So we change these tests to not rely on domain. The test still passes for Chrome.

…fault secure

Added tests:
1. Check that set/get/getAll are using the context's creation URL
2. Check that set fails if certain control characters are present in the name or value
3. Check that CookieListItem is secure by default (we want to test this property individually
   since the other tests in set_arguments check other properties first--so failing one of the
   earlier properties means we never check the secure property)

Changed tests:
1. There are two tests in set_arguments and delete_arguments that pass in the result of
   get() to delete(). These tests indirectly depend on the domain property. But Safari/Mozilla
   don't support domain being returned by get(). So we change these tests to not rely on domain.
   The test still passes for Chrome.
@cdumez cdumez merged commit 109d4a6 into web-platform-tests:master Jan 16, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants