Add test for calling worker constructor from a shared worker. #50017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface - Calling the Worker constructor from Window is covered by worker-constructor.html - Calling the Worker constructor from a DedicatedWorker is covered by WorkerGlobalScope-worker-constructor.html - This patch extends the previous test to also cover the case when the Worker constructor is called from a SharedWorker. w3c/trusted-types#567
lukewarlow
approved these changes
Jan 10, 2025
|
mmh, I actually forgot to add the actual sink check will do it now... |
It passes in Firefox with my my extra dev patches. Trying in Chromium release and Safari Tech preview, the trusted type check seems to fail for the Worker constructor in workers. And Worker does not seem to be exposed at all to SharedWorker (which is not related to TT). I believe I saw similar issues for other worker tests like importScripts. |
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add test for calling worker constructor from a shared worker. See https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface - Calling the Worker constructor from Window is covered by worker-constructor.html - Calling the Worker constructor from a DedicatedWorker is covered by WorkerGlobalScope-worker-constructor.html - This patch extends the previous test to also cover the case when the Worker constructor is called from a SharedWorker. w3c/trusted-types#567 * actually perform check for the sink value...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface
w3c/trusted-types#567