Use wrapper divs in trusted-types-createHTMLDocument.html #50000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it uses `doc.body` but when `doc == document`, this is causing errors in `testharness.js`: `TypeError: can't access property "addEventListener", output_document.getElementById(...) is null`
lukewarlow
approved these changes
Jan 9, 2025
Basically testharness.js adds some internal div with specific ids for its own reports (like tests running, pending, detailed results etc). The test does document.body.innerHTML = "..." which erases the whole doc content, and that does not interact well with testharness.js code... |
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
Currently it uses `doc.body` but when `doc == document`, this is causing errors in `testharness.js`: `TypeError: can't access property "addEventListener", output_document.getElementById(...) is null`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it uses
doc.bodybut whendoc == document, this is causing errors intestharness.js:TypeError: can't access property "addEventListener", output_document.getElementById(...) is null