Add more TrustedType tests for eval and function constructor. #49997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have many tests for eval and function constructor but things are a bit messy and it's difficult to figure out what we are covering. Write a simple test to test blocking, compilationSink and execution in workers.
lukewarlow
requested changes
Jan 9, 2025
Good point. I also added tests for other function constructor, for completeness |
lukewarlow
approved these changes
Jan 9, 2025
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add more TrustedType tests for eval and function constructor. We already have many tests for eval and function constructor but things are a bit messy and it's difficult to figure out what we are covering. Write a simple test to test blocking, compilationSink and execution in workers. * also test indirect eval and more function constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have many tests for eval and function constructor but things are a bit messy and it's difficult to figure out what we are covering. Write a simple test to test blocking, compilationSink and execution in workers.