import.meta.url should include the URL fragment #32704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update workers/modules/shared-worker-import-meta.html to expect import.meta.url to include the URL fragment. This matches the behavior of both WebKit and Blink. See whatwg/html#5162 for more information.
|
cc @domenic |
nt1m
approved these changes
Feb 5, 2022
annevk
approved these changes
Feb 7, 2022
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 8, 2022
https://bugs.webkit.org/show_bug.cgi?id=236302 Reviewed by Yusuke Suzuki. Resync workers/modules/shared-worker-import-meta.html from upstream WPT after web-platform-tests/wpt#32704. * web-platform-tests/workers/modules/shared-worker-import-meta-expected.txt: * web-platform-tests/workers/modules/shared-worker-import-meta.html: Canonical link: https://commits.webkit.org/246984@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
annulen
pushed a commit
to qtwebkit/qtwebkit
that referenced
this pull request
Feb 9, 2022
https://bugs.webkit.org/show_bug.cgi?id=236302 Reviewed by Yusuke Suzuki. Resync workers/modules/shared-worker-import-meta.html from upstream WPT after web-platform-tests/wpt#32704. * web-platform-tests/workers/modules/shared-worker-import-meta-expected.txt: * web-platform-tests/workers/modules/shared-worker-import-meta.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@289424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update workers/modules/shared-worker-import-meta.html to expect import.meta.url to include
the URL fragment. This matches the behavior of both WebKit and Blink.
See whatwg/html#5162 for more information.