[webtransport] Set ENABLE_CONNECT_PROTOCOL settings flag #31573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to use an Extended CONNECT method. WebTransport uses an Extended CONNECT method.
|
The CI error doesn't seem to be specific to this PR. $ make html
# ...
Running Sphinx v2.4.4
Warning, treated as error:
node class 'meta' is already registered, its visitors will be overridden
make: *** [Makefile:24: html] Error 2
rm tools/webtransport tools/wptserve tools/third_party/pywebsocket3 tools/wptrunner tools/certs
zsh: exit 2 make htmlMaybe we should update sphinx version or specify docutil version? |
|
@foolip Friendly ping. Could you give advice on how to merge this PR? |
|
Thank you for merging! |
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…m-tests#31573) This is required to use an Extended CONNECT method. WebTransport uses an Extended CONNECT method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to use an Extended CONNECT method. WebTransport
uses an Extended CONNECT method.