Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=225997 #29767

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh commented Jul 23, 2021

Follow-up of #29027.

This upstream reviewed change tests that cross-realm WebIDL getters and setters throw TypeError in realm of their holder, including global object's accessors called with this value of undefined and null.

Also, asserts that cross-realm PerformanceObserver.supportedEntryTypes returns a cross-realm array.

@wpt-pr-bot
Copy link
Collaborator

This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+.

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the WebKit project.

@shvaikalesh shvaikalesh merged commit abea83b into web-platform-tests:master Jul 23, 2021
@shvaikalesh shvaikalesh deleted the cross-realm-getter-setter-realm branch July 23, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants