-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up more around base64.decodebytes() calls #28757
Conversation
49a9136
to
a7dac97
Compare
Care must be taken when merging this and #28789. Both change |
Follow-up to #28747.
Thanks @jgraham! Just to be sure I've rebased to trigger another run, and will check if any of the changes are consistent regressions before landing. |
Alright, in the latest run Firefox had no regressions. Safari did, and here's the combination of 4 runs: With that, the only candidate regression is "AssertionError: session not created (500): Could not create a session: The Safari instance terminated while trying to pair with it." which I'm confident I didn't cause here. |
Follow-up to #28747.