Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all uses of six.move by the Python 3-only equivalent #28735

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 29, 2021

To improve confidence that this will work in Python 3.6, all of the
unique import statements were tested in Python 3.5.5 and 3.6.8:

from http.client import HTTPConnection
from urllib.parse import parse_qs
from urllib.parse import parse_qs, quote
from urllib.parse import parse_qsl, SplitResult, urlencode, urlsplit, urlunsplit
from urllib.parse import unquote
from urllib.parse import urlencode
from urllib.parse import urlencode, urlparse
from urllib.parse import urlparse
from urllib.parse import urlunsplit
import urllib

@foolip
Copy link
Member Author

foolip commented Apr 29, 2021

I've looked through the before/after results and don't think I've caused any of the changes in webdriver for Firefox and Safari:
https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&q=is%3Adifferent&run_id=5676157900947456&run_id=5656274618286080
https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&q=is%3Adifferent&run_id=5676288159252480&run_id=5181381359435776

But there are "setup error" failures which might be how a failure manifests, so I'm going to have to take a closer look.

@andreastt andreastt removed their request for review April 29, 2021 12:57
To improve confidence that this will work in Python 3.6, all of the
unique import statements were tested in Python 3.5.5 and 3.6.8:
```py
from http.client import HTTPConnection
from urllib.parse import parse_qs
from urllib.parse import parse_qs, quote
from urllib.parse import parse_qsl, SplitResult, urlencode, urlsplit, urlunsplit
from urllib.parse import unquote
from urllib.parse import urlencode
from urllib.parse import urlencode, urlparse
from urllib.parse import urlparse
from urllib.parse import urlunsplit
import urllib
```
@foolip
Copy link
Member Author

foolip commented Apr 29, 2021

I rebased to trigger CI again, here are the before/after of Chrome/Safari:
https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&q=is%3Adifferent&run_id=5692740903895040&run_id=4823262422892544
https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&q=is%3Adifferent&run_id=5733793677705216&run_id=5109353482813440

Comparing that with the diffs in #28735 (comment) I'm now confident these aren't regressions of these change. There doesn't seem to be any test that passed both times without the changes and then failed both times with the changes.

@foolip foolip merged commit da93406 into master Apr 29, 2021
@foolip foolip deleted the six.moves branch April 29, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants